fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor: enforce layer discipline — move repositories, fix constructor injection

Browse Source 
- Move HelpdeskTenantSettingsRepository and HelpdeskTokenRepository from
  Service/ to Repository/ directory (GR-SEC-003: SQL only in repositories)
- Make AccessControl constructor require IntendedUrlService explicitly
  instead of falling back to `new IntendedUrlService()` (GR-TEST-002:
  no service instantiation outside factories)
- Update all imports and tests accordingly

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-04-13 19:28:07 +02:00
parent a17c2c7cea
commit 4e6b586b77
10 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/helpdesk/lib/Module/Helpdesk/HelpdeskContainerRegistrar.php
View File

@@ -13,8 +13,8 @@ use MintyPHP\Module\Helpdesk\Service\EffectiveHelpdeskSettingsService;
use MintyPHP\Module\Helpdesk\Service\HelpdeskOAuthTokenService;
use MintyPHP\Module\Helpdesk\Service\HelpdeskSettingsGateway;
use MintyPHP\Module\Helpdesk\Service\HelpdeskTenantSettingsGateway;
use MintyPHP\Module\Helpdesk\Service\HelpdeskTenantSettingsRepository;
use MintyPHP\Module\Helpdesk\Service\HelpdeskTokenRepository;
use MintyPHP\Module\Helpdesk\Repository\HelpdeskTenantSettingsRepository;
use MintyPHP\Module\Helpdesk\Repository\HelpdeskTokenRepository;
use MintyPHP\Module\Helpdesk\Service\SystemRecommendationEngine;
use MintyPHP\Module\Helpdesk\Service\TicketCommunicationService;
use MintyPHP\Service\Access\PermissionService;

2
modules/helpdesk/lib/Module/Helpdesk/Service/HelpdeskTenantSettingsRepository.php → modules/helpdesk/lib/Module/Helpdesk/Repository/HelpdeskTenantSettingsRepository.php
View File

@@ -1,6 +1,6 @@
<?php
namespace MintyPHP\Module\Helpdesk\Service;
namespace MintyPHP\Module\Helpdesk\Repository;
use MintyPHP\DB;

2
modules/helpdesk/lib/Module/Helpdesk/Service/HelpdeskTokenRepository.php → modules/helpdesk/lib/Module/Helpdesk/Repository/HelpdeskTokenRepository.php
View File

@@ -1,6 +1,6 @@
<?php
namespace MintyPHP\Module\Helpdesk\Service;
namespace MintyPHP\Module\Helpdesk\Repository;
use MintyPHP\DB;
use MintyPHP\Service\Settings\SettingsCryptoGatewayInterface;

2
modules/helpdesk/lib/Module/Helpdesk/Service/HelpdeskOAuthTokenService.php
View File

@@ -2,6 +2,8 @@
namespace MintyPHP\Module\Helpdesk\Service;
use MintyPHP\Module\Helpdesk\Repository\HelpdeskTokenRepository;
/**
* OAuth2 client_credentials token service for BC OData access.
*

1
modules/helpdesk/lib/Module/Helpdesk/Service/HelpdeskTenantSettingsGateway.php
View File

@@ -2,6 +2,7 @@
namespace MintyPHP\Module\Helpdesk\Service;
use MintyPHP\Module\Helpdesk\Repository\HelpdeskTenantSettingsRepository;
use MintyPHP\Service\Settings\SettingsCryptoGatewayInterface;
/**