fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor: fix all 105 PHPStan 2 strict type findings across core and modules

Browse Source 
Resolve all non-false-positive PHPStan 2 findings, reducing the baseline
from 486 to 382 entries (only unused-public false positives remain).

Categories fixed:
- Remove 39 redundant type checks (is_string, is_array, is_object, method_exists)
- Remove 12 no-op array_values() on already-sequential lists
- Simplify 13 null-coalesce on guaranteed offsets
- Remove 8 always-true instanceof checks
- Replace 12 redundant test assertions (assertTrue(true) → addToAssertionCount)
- Simplify 6 unnecessary nullsafe operators (?-> → ->)
- Fix 6 always-true !== '' comparisons
- Fix remaining: unset.offset, return.unusedType, staticMethod narrowing

53 files changed across core/, modules/, pages/, and tests/.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-04-14 12:54:20 +02:00
parent a736566071
commit 3f0db68b27
53 changed files with 90 additions and 640 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/Support/AppContainerIsolationTraitTest.php
View File

@@ -9,7 +9,7 @@ final class AppContainerIsolationTraitTest extends TestCase
{
public function testPushAndRestoreRoundTripKeepsOriginalGlobalContainer(): void
{
$original = $GLOBALS['minty_app_container'] ?? null;
$original = $GLOBALS['minty_app_container'];
self::assertInstanceOf(AppContainer::class, $original);
$harness = new class () {
@@ -29,16 +29,16 @@ final class AppContainerIsolationTraitTest extends TestCase
$replacement = new AppContainer();
$harness->push($replacement);
self::assertSame($replacement, $GLOBALS['minty_app_container'] ?? null);
self::assertSame($replacement, $GLOBALS['minty_app_container']);
$harness->restore();
self::assertSame($original, $GLOBALS['minty_app_container'] ?? null);
self::assertSame($original, $GLOBALS['minty_app_container']);
}
public function testMultiplePushesRestoreToInitialContainer(): void
{
$original = $GLOBALS['minty_app_container'] ?? null;
$original = $GLOBALS['minty_app_container'];
self::assertInstanceOf(AppContainer::class, $original);
$harness = new class () {
@@ -61,10 +61,10 @@ final class AppContainerIsolationTraitTest extends TestCase
$harness->push($first);
$harness->push($second);
self::assertSame($second, $GLOBALS['minty_app_container'] ?? null);
self::assertSame($second, $GLOBALS['minty_app_container']);
$harness->restore();
self::assertSame($original, $GLOBALS['minty_app_container'] ?? null);
self::assertSame($original, $GLOBALS['minty_app_container']);
}
}