fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor: fix all 105 PHPStan 2 strict type findings across core and modules

Browse Source 
Resolve all non-false-positive PHPStan 2 findings, reducing the baseline
from 486 to 382 entries (only unused-public false positives remain).

Categories fixed:
- Remove 39 redundant type checks (is_string, is_array, is_object, method_exists)
- Remove 12 no-op array_values() on already-sequential lists
- Simplify 13 null-coalesce on guaranteed offsets
- Remove 8 always-true instanceof checks
- Replace 12 redundant test assertions (assertTrue(true) → addToAssertionCount)
- Simplify 6 unnecessary nullsafe operators (?-> → ->)
- Fix 6 always-true !== '' comparisons
- Fix remaining: unset.offset, return.unusedType, staticMethod narrowing

53 files changed across core/, modules/, pages/, and tests/.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-04-14 12:54:20 +02:00
parent a736566071
commit 3f0db68b27
53 changed files with 90 additions and 640 deletions
Download Patch File Download Diff File Expand all files Collapse all files

426
phpstan-baseline.neon
View File

@@ -12,18 +12,6 @@ parameters:
count: 1
path: core/App/Bootstrap/EnvValidator.php
-
message: '#^Call to function is_string\(\) with class\-string will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 4
path: core/App/Module/ModuleRegistry.php
-
message: '#^Parameter \#1 \$array \(list\<string\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 2
path: core/App/Module/ModuleRegistry.php
-
message: '#^Public method "MintyPHP\\App\\Module\\ModuleRegistry\:\:getModule\(\)" is never used$#'
identifier: public.method.unused
@@ -48,12 +36,6 @@ parameters:
count: 1
path: core/App/Module/ModuleRegistry.php
-
message: '#^Instanceof between MintyPHP\\App\\Module\\ModuleManifest and MintyPHP\\App\\Module\\ModuleManifest will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: core/App/Module/ModuleRuntimeAssetPublisher.php
-
message: '#^Public method "MintyPHP\\App\\Module\\ModuleRuntimePageBuilder\:\:expectedFingerprint\(\)" is never used$#'
identifier: public.method.unused
@@ -78,12 +60,6 @@ parameters:
count: 1
path: core/Console/ConsoleApplication.php
-
message: '#^Instanceof between MintyPHP\\App\\AppContainer and MintyPHP\\App\\AppContainer will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: core/Console/Runner/Doctor/DoctorRunner.php
-
message: '#^Public method "MintyPHP\\Console\\Support\\ModuleCliRuntime\:\:bootstrap\(\)" is never used$#'
identifier: public.method.unused
@@ -132,30 +108,6 @@ parameters:
count: 1
path: core/Http/ApiAuth.php
-
message: '#^Call to function is_object\(\) with object will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 4
path: core/Http/ApiBootstrap.php
-
message: '#^Offset 0 on non\-empty\-list\<string\> on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 1
path: core/Http/ApiBootstrap.php
-
message: '#^Call to function is_object\(\) with object will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 3
path: core/Http/ApiResponse.php
-
message: '#^Instanceof between MintyPHP\\Service\\Access\\AuthorizationService and MintyPHP\\Service\\Access\\AuthorizationService will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: core/Http/ApiResponse.php
-
message: '#^Public method "MintyPHP\\Http\\ApiResponse\:\:readJsonBody\(\)" is never used$#'
identifier: public.method.unused
@@ -252,12 +204,6 @@ parameters:
count: 1
path: core/Http/RequestContext.php
-
message: '#^Offset 0 on non\-empty\-list\<string\> on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 1
path: core/Http/RequestRuntime.php
-
message: '#^Public method "MintyPHP\\Http\\RouteCatalog\:\:corePublicPaths\(\)" is never used$#'
identifier: public.method.unused
@@ -288,24 +234,6 @@ parameters:
count: 1
path: core/Repository/CustomField/TenantCustomFieldDefinitionRepository.php
-
message: '#^Using nullsafe property access "\?\-\>value" on left side of \?\? is unnecessary\. Use \-\> instead\.$#'
identifier: nullsafe.neverNull
count: 1
path: core/Repository/Mail/MailLogRepository.php
-
message: '#^Cannot unset offset ''this'' on array\{tenantActiveStatus\: ''active'', tenantInactiveStatus\: ''inactive'', importStatusRunning\: ''running'', importStatusSuccess\: ''success'', importStatusPartial\: ''partial'', importStatusFailed\: ''failed'', systemAuditOutcomeFailed\: ''failed'', systemAuditOutcomeDenied\: ''denied'', \.\.\.\}\.$#'
identifier: unset.offset
count: 1
path: core/Repository/Stats/AdminStatsRepository.php
-
message: '#^Call to function is_string\(\) with class\-string will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Service/Access/AccessPolicyFactory.php
-
message: '#^Public method "MintyPHP\\Service\\Access\\AccessServicesFactory\:\:createAuthorizationService\(\)" is never used$#'
identifier: public.method.unused
@@ -384,12 +312,6 @@ parameters:
count: 1
path: core/Service/Access/AuthorizationDecision.php
-
message: '#^Instanceof between MintyPHP\\Service\\Access\\AuthorizationPolicyInterface and MintyPHP\\Service\\Access\\AuthorizationPolicyInterface will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: core/Service/Access/AuthorizationService.php
-
message: '#^Public method "MintyPHP\\Service\\Access\\AuthorizationService\:\:allow\(\)" is never used$#'
identifier: public.method.unused
@@ -486,18 +408,6 @@ parameters:
count: 1
path: core/Service/Access/RoleService.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Service/Access/UiAccessService.php
-
message: '#^Call to function is_array\(\) with array\{ability\: string, context\?\: array\<string, mixed\>\} will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Service/Access/UiAccessService.php
-
message: '#^Public method "MintyPHP\\Service\\Access\\UiAccessService\:\:layoutCapabilities\(\)" is never used$#'
identifier: public.method.unused
@@ -834,18 +744,6 @@ parameters:
count: 1
path: core/Service/Auth/TenantSsoService.php
-
message: '#^Strict comparison using \!\=\= between mixed~'''' and '''' will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: core/Service/Auth/TenantSsoService.php
-
message: '#^Offset 0 on non\-empty\-list\<string\> on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 1
path: core/Service/Branding/BrandingFaviconService.php
-
message: '#^Public method "MintyPHP\\Service\\Branding\\BrandingFaviconService\:\:hasFavicon\(\)" is never used$#'
identifier: public.method.unused
@@ -858,12 +756,6 @@ parameters:
count: 1
path: core/Service/Branding/BrandingFaviconService.php
-
message: '#^Offset 0 on non\-empty\-list\<string\> on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 2
path: core/Service/Branding/BrandingLogoService.php
-
message: '#^Public method "MintyPHP\\Service\\Branding\\BrandingLogoService\:\:saveUpload\(\)" is never used$#'
identifier: public.method.unused
@@ -930,12 +822,6 @@ parameters:
count: 1
path: core/Service/CustomField/TenantCustomFieldService.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Service/CustomField/UserCustomFieldValueService.php
-
message: '#^Public method "MintyPHP\\Service\\CustomField\\UserCustomFieldValueService\:\:buildPublicValuesByTenant\(\)" is never used$#'
identifier: public.method.unused
@@ -990,12 +876,6 @@ parameters:
count: 1
path: core/Service/Docs/DocsCatalogService.php
-
message: '#^Call to function is_array\(\) with non\-empty\-list\<string\|null\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 2
path: core/Service/Import/CsvReaderService.php
-
message: '#^Public method "MintyPHP\\Service\\Import\\ImportService\:\:analyzeUpload\(\)" is never used$#'
identifier: public.method.unused
@@ -1104,12 +984,6 @@ parameters:
count: 1
path: core/Service/Org/DepartmentService.php
-
message: '#^Parameter \#1 \$array \(list\<string\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 1
path: core/Service/Scheduler/ScheduledJobRegistry.php
-
message: '#^Public constant "MintyPHP\\Service\\Scheduler\\ScheduledJobRegistry\:\:USER_LIFECYCLE_RUN" is never used$#'
identifier: public.classConstant.unused
@@ -1170,12 +1044,6 @@ parameters:
count: 1
path: core/Service/Scheduler/SchedulerRunService.php
-
message: '#^Using nullsafe property access "\?\-\>value" on left side of \?\? is unnecessary\. Use \-\> instead\.$#'
identifier: nullsafe.neverNull
count: 1
path: core/Service/Scheduler/SchedulerRunService.php
-
message: '#^Public method "MintyPHP\\Service\\Scheduler\\SchedulerServicesFactory\:\:createSchedulerRunService\(\)" is never used$#'
identifier: public.method.unused
@@ -1308,12 +1176,6 @@ parameters:
count: 1
path: core/Service/System/SystemInfoService.php
-
message: '#^Offset 0 on non\-empty\-list\<string\> on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 2
path: core/Service/Tenant/TenantAvatarService.php
-
message: '#^Public method "MintyPHP\\Service\\Tenant\\TenantAvatarService\:\:hasAvatar\(\)" is never used$#'
identifier: public.method.unused
@@ -1326,12 +1188,6 @@ parameters:
count: 1
path: core/Service/Tenant/TenantAvatarService.php
-
message: '#^Offset 0 on non\-empty\-list\<string\> on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 1
path: core/Service/Tenant/TenantFaviconService.php
-
message: '#^Public method "MintyPHP\\Service\\Tenant\\TenantFaviconService\:\:hasFavicon\(\)" is never used$#'
identifier: public.method.unused
@@ -1398,24 +1254,6 @@ parameters:
count: 1
path: core/Service/Tenant/TenantServicesFactory.php
-
message: '#^Call to function method_exists\(\) with Dompdf\\Options and ''setDefaultFont'' will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Service/User/UserAccessPdfService.php
-
message: '#^Call to function method_exists\(\) with Dompdf\\Options and ''setIsPhpEnabled'' will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Service/User/UserAccessPdfService.php
-
message: '#^Call to function method_exists\(\) with Dompdf\\Options and ''setIsRemoteEnabled'' will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Service/User/UserAccessPdfService.php
-
message: '#^Public method "MintyPHP\\Service\\User\\UserAccessPdfService\:\:renderUsersAccessZip\(\)" is never used$#'
identifier: public.method.unused
@@ -1500,12 +1338,6 @@ parameters:
count: 1
path: core/Service/User/UserAssignmentService.php
-
message: '#^Offset 0 on non\-empty\-list\<string\> on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 2
path: core/Service/User/UserAvatarService.php
-
message: '#^Public method "MintyPHP\\Service\\User\\UserAvatarService\:\:saveUpload\(\)" is never used$#'
identifier: public.method.unused
@@ -1578,24 +1410,6 @@ parameters:
count: 1
path: core/Support/Flash.php
-
message: '#^Instanceof between MintyPHP\\Service\\Access\\AuthorizationService and MintyPHP\\Service\\Access\\AuthorizationService will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: core/Support/Guard.php
-
message: '#^Instanceof between MintyPHP\\Service\\Auth\\AuthService and MintyPHP\\Service\\Auth\\AuthService will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: core/Support/Guard.php
-
message: '#^Instanceof between MintyPHP\\Service\\Tenant\\TenantService and MintyPHP\\Service\\Tenant\\TenantService will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: core/Support/Guard.php
-
message: '#^Public method "MintyPHP\\Support\\Search\\SearchSqlResourceProvider\:\:resourceKeys\(\)" is never used$#'
identifier: public.method.unused
@@ -1614,12 +1428,6 @@ parameters:
count: 1
path: core/Support/Search/SearchUiMetaProvider.php
-
message: '#^Instanceof between MintyPHP\\App\\Module\\ModuleRegistry and MintyPHP\\App\\Module\\ModuleRegistry will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: core/Support/SearchConfig.php
-
message: '#^Public method "MintyPHP\\Support\\SearchConfig\:\:iconForKey\(\)" is never used$#'
identifier: public.method.unused
@@ -1638,42 +1446,6 @@ parameters:
count: 1
path: core/Support/Tile.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Support/helpers/app.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 4
path: core/Support/helpers/grid.php
-
message: '#^Call to function is_array\(\) with array\<int\|string, array\<mixed\>\|string\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 2
path: core/Support/helpers/request.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Support/helpers/ui.php
-
message: '#^Call to function is_array\(\) with list\<string\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Support/helpers/ui.php
-
message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: core/Support/helpers/ui.php
-
message: '#^Public constant "MintyPHP\\Module\\AddressBook\\AddressBookAuthorizationPolicy\:\:PERMISSION_KEY" is never used$#'
identifier: public.classConstant.unused
@@ -1728,12 +1500,6 @@ parameters:
count: 1
path: modules/audit/lib/Module/Audit/Domain/UserLifecycleTriggerType.php
-
message: '#^Using nullsafe property access "\?\-\>value" on left side of \?\? is unnecessary\. Use \-\> instead\.$#'
identifier: nullsafe.neverNull
count: 3
path: modules/audit/lib/Module/Audit/Repository/UserLifecycleAuditRepository.php
-
message: '#^Public method "MintyPHP\\Module\\Audit\\Service\\ApiAuditService\:\:filterOptions\(\)" is never used$#'
identifier: public.method.unused
@@ -1752,18 +1518,6 @@ parameters:
count: 1
path: modules/audit/lib/Module/Audit/Service/ApiAuditService.php
-
message: '#^Call to function is_int\(\) with int will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: modules/audit/lib/Module/Audit/Service/FrontendTelemetryIngestService.php
-
message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: modules/audit/lib/Module/Audit/Service/FrontendTelemetryIngestService.php
-
message: '#^Public method "MintyPHP\\Module\\Audit\\Service\\FrontendTelemetryIngestService\:\:ingest\(\)" is never used$#'
identifier: public.method.unused
@@ -1824,18 +1578,6 @@ parameters:
count: 1
path: modules/audit/lib/Module/Audit/Service/UserLifecycleAuditService.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: 'modules/audit/pages/audit/frontend-telemetry/ingest().php'
-
message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: 'modules/audit/pages/audit/frontend-telemetry/ingest().php'
-
message: '#^Public method "MintyPHP\\Module\\Bookmarks\\Service\\BookmarkService\:\:allowedGroupIconLabels\(\)" is never used$#'
identifier: public.method.unused
@@ -1926,12 +1668,6 @@ parameters:
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Repository/HelpdeskTokenRepository.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 2
path: modules/helpdesk/lib/Module/Helpdesk/Service/BcODataGateway.php
-
message: '#^Public constant "MintyPHP\\Module\\Helpdesk\\Service\\BcODataGateway\:\:ENTITY_CONTACT" is never used$#'
identifier: public.classConstant.unused
@@ -2016,12 +1752,6 @@ parameters:
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/BcODataGateway.php
-
message: '#^Strict comparison using \!\=\= between list\{0\: ''Name ne \\''\\'''', 1\?\: non\-empty\-string, 2\?\: non\-empty\-string\} and array\{\} will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/BcODataGateway.php
-
message: '#^Public method "MintyPHP\\Module\\Helpdesk\\Service\\BcSoapGateway\:\:getTicketFile\(\)" is never used$#'
identifier: public.method.unused
@@ -2106,12 +1836,6 @@ parameters:
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/DebitorDetailService.php
-
message: '#^Strict comparison using \!\=\= between non\-empty\-string and '''' will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/DebitorDetailService.php
-
message: '#^Public constant "MintyPHP\\Module\\Helpdesk\\Service\\DebitorSearchService\:\:MIN_QUERY_LENGTH" is never used$#'
identifier: public.classConstant.unused
@@ -2340,108 +2064,24 @@ parameters:
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/HelpdeskTenantSettingsGateway.php
-
message: '#^Strict comparison using \!\=\= between non\-empty\-string and '''' will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/RiskRadarService.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/SystemRecommendationEngine.php
-
message: '#^Parameter \#1 \$array \(list\<string\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/SystemRecommendationEngine.php
-
message: '#^Public method "MintyPHP\\Module\\Helpdesk\\Service\\SystemRecommendationEngine\:\:buildRecommendations\(\)" is never used$#'
identifier: public.method.unused
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/SystemRecommendationEngine.php
-
message: '#^Call to function is_array\(\) with array\<string, mixed\> will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 2
path: modules/helpdesk/lib/Module/Helpdesk/Service/TicketCommunicationService.php
-
message: '#^Public method "MintyPHP\\Module\\Helpdesk\\Service\\TicketCommunicationService\:\:loadDebitorCommunicationFeed\(\)" is never used$#'
identifier: public.method.unused
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/TicketCommunicationService.php
-
message: '#^Strict comparison using \!\=\= between non\-falsy\-string and '''' will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: modules/helpdesk/lib/Module/Helpdesk/Service/TicketCommunicationService.php
-
message: '#^Parameter \#1 \$array \(list\<array\{Name\: string, Type\: string, Job_Title\: string, E_Mail\: string, Phone_No\: string, Mobile_Phone_No\: string\}\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 1
path: 'modules/helpdesk/pages/helpdesk/debitor-contacts-data().php'
-
message: '#^Parameter \#1 \$array \(list\<non\-empty\-string\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 3
path: 'modules/helpdesk/pages/helpdesk/debitor-ticket-categories-data().php'
-
message: '#^Parameter \#1 \$array \(list\<array\{No\: string, Description\: string, Ticket_State\: string, state_variant\: ''neutral''\|''success''\|''warning'', Category_1_Description\: string, Support_User_Name\: string, Current_Contact_Name\: string, Created_On\: string, \.\.\.\}\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 1
path: 'modules/helpdesk/pages/helpdesk/debitor-tickets-data().php'
-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertIsArray\(\) with array\<int, array\<string, mixed\>\> will always evaluate to true\.$#'
identifier: method.alreadyNarrowedType
count: 2
path: modules/helpdesk/tests/Module/Helpdesk/Service/BcODataGatewayTest.php
-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
identifier: method.alreadyNarrowedType
count: 6
path: modules/helpdesk/tests/Module/Helpdesk/Service/BcODataGatewayTest.php
-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
identifier: method.alreadyNarrowedType
count: 3
path: modules/helpdesk/tests/Module/Helpdesk/Service/DebitorDetailServiceTest.php
-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertIsArray\(\) with array\<int, array\<string, string\>\> will always evaluate to true\.$#'
identifier: method.alreadyNarrowedType
count: 1
path: modules/helpdesk/tests/Module/Helpdesk/Service/TicketCommunicationServiceTest.php
-
message: '#^Public constant "MintyPHP\\Module\\Notifications\\NotificationsAuthorizationPolicy\:\:PERMISSION_KEY" is never used$#'
identifier: public.classConstant.unused
count: 1
path: modules/notifications/lib/Module/Notifications/NotificationsAuthorizationPolicy.php
-
message: '#^Parameter \#1 \$array \(list\<bool\|float\|int\|string\|null\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 1
path: modules/notifications/lib/Module/Notifications/Service/NotificationMessage.php
-
message: '#^Parameter \#1 \$array \(list\<bool\|float\|int\|string\|null\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 1
path: modules/notifications/lib/Module/Notifications/Service/NotificationService.php
-
message: '#^Public method "MintyPHP\\Module\\Notifications\\Service\\NotificationService\:\:createForTenantAdminUsers\(\)" is never used$#'
identifier: public.method.unused
@@ -2484,30 +2124,6 @@ parameters:
count: 1
path: modules/notifications/lib/Module/Notifications/Service/NotificationService.php
-
message: '#^Offset ''key'' on array\{key\: string, label\: string, allowed\: true, permission\: mixed\} on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 1
path: 'pages/admin/imports/index().php'
-
message: '#^Using nullsafe property access "\?\-\>value" on left side of \?\? is unnecessary\. Use \-\> instead\.$#'
identifier: nullsafe.neverNull
count: 1
path: 'pages/admin/scheduled-jobs/data().php'
-
message: '#^Strict comparison using \!\=\= between lowercase\-string&non\-empty\-string and '''' will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: 'pages/auth/login().php'
-
message: '#^Method MintyPHP\\Tests\\App\\Module\\InMemoryPermissionRepository\:\:create\(\) never returns null so it can be removed from the return type\.$#'
identifier: return.unusedType
count: 1
path: tests/App/Module/ModulePermissionSynchronizerTest.php
-
message: '#^Public method "MintyPHP\\Tests\\Architecture\\AuthHelpLinksContractFiles\:\:secondaryAuthPages\(\)" is never used$#'
identifier: public.method.unused
@@ -2550,18 +2166,6 @@ parameters:
count: 1
path: tests/Architecture/ListTitlebarContractFiles.php
-
message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertIsString\(\) with string will always evaluate to true\.$#'
identifier: staticMethod.alreadyNarrowedType
count: 1
path: tests/Architecture/ModuleManifestContractTest.php
-
message: '#^Parameter \#1 \$array \(list\<string\>\) of array_values is already a list, call has no effect\.$#'
identifier: arrayValues.list
count: 1
path: tests/Architecture/ModuleUiContractTest.php
-
message: '#^Public method "MintyPHP\\Tests\\Architecture\\StatusTaxonomyContractFiles\:\:forbiddenLiteralPatterns\(\)" is never used$#'
identifier: public.method.unused
@@ -2646,12 +2250,6 @@ parameters:
count: 1
path: tests/Console/ModuleCommandsTest.php
-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
identifier: method.alreadyNarrowedType
count: 2
path: tests/Http/ErrorHandlerTest.php
-
message: '#^Public constant "MintyPHP\\Tests\\Service\\Access\\TestMultiDependencyPolicy\:\:ABILITY" is never used$#'
identifier: public.classConstant.unused
@@ -2670,30 +2268,6 @@ parameters:
count: 1
path: tests/Service/Auth/AuthSessionTenantContextServiceTest.php
-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertIsArray\(\) with array\<int, array\{action_key\: string, mac\: string, win\: string\}\> will always evaluate to true\.$#'
identifier: method.alreadyNarrowedType
count: 1
path: tests/Service/Ui/HotkeyServiceTest.php
-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertIsArray\(\) with array\<string\> will always evaluate to true\.$#'
identifier: method.alreadyNarrowedType
count: 1
path: tests/Service/Ui/HotkeyServiceTest.php
-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertIsString\(\) with string will always evaluate to true\.$#'
identifier: method.alreadyNarrowedType
count: 1
path: tests/Service/Ui/HotkeyServiceTest.php
-
message: '#^Offset ''minty_app_container'' on non\-empty\-array\<mixed\> on left side of \?\? always exists and is not nullable\.$#'
identifier: nullCoalesce.offset
count: 2
path: tests/Support/AppContainerIsolationTraitTest.php
-
message: '#^Public method "AnonymousClass1c441bccb4cb10bf3a2542eabe719765\:\:push\(\)" is never used$#'
identifier: public.method.unused