refactor: extract shared code from bin/ scripts and remove legacy scheduler runner

- Extract ModuleManifestLoader for standalone manifest loading (used by module-deactivate and ValidateCommand) - Extract SqlStatementParser, ModuleMigrationRepository, and ModuleMigrationService from bin/module-migrate.php to enforce strict layering (SQL in repository, orchestration in service) - Delete bin/scheduler-run.php (fully superseded by bin/console scheduler:run) - Update docs and test fixtures to reference bin/console Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-22 13:45:16 +01:00
parent e06e5bde03
commit 141f0a0155
14 changed files with 487 additions and 300 deletions
--- a/lib/Service/Module/ModuleMigrationService.php
+++ b/lib/Service/Module/ModuleMigrationService.php
@@ -0,0 +1,100 @@
+<?php
+
+namespace MintyPHP\Service\Module;
+
+use MintyPHP\App\Module\ModuleRegistry;
+use MintyPHP\Repository\Module\ModuleMigrationRepository;
+use MintyPHP\Support\SqlStatementParser;
+use RuntimeException;
+
+/**
+ * Discovers and applies pending SQL migrations for all enabled modules.
+ *
+ * Orchestration only — SQL lives in ModuleMigrationRepository,
+ * statement parsing in SqlStatementParser.
+ */
+final class ModuleMigrationService
+{
+    public function __construct(
+        private readonly ModuleRegistry $registry,
+        private readonly ModuleMigrationRepository $repository,
+    ) {}
+
+    /**
+     * Apply all pending module migrations.
+     *
+     * @return array{ok: bool, applied: int}
+     */
+    public function applyPendingMigrations(): array
+    {
+        $modules = $this->registry->getModules();
+
+        if (count($modules) === 0) {
+            fwrite(STDOUT, "module-migrate: no modules enabled, nothing to do.\n");
+            return ['ok' => true, 'applied' => 0];
+        }
+
+        $this->repository->ensureTrackingTable();
+
+        $totalApplied = 0;
+
+        foreach ($modules as $manifest) {
+            $migrationsPath = $manifest->migrationsPath;
+            if ($migrationsPath === null || !is_dir($migrationsPath)) {
+                continue;
+            }
+
+            $files = glob($migrationsPath . '/*.sql');
+            if ($files === false || count($files) === 0) {
+                continue;
+            }
+            sort($files);
+
+            $applied = $this->repository->getAppliedFilenames((string) $manifest->id);
+
+            foreach ($files as $file) {
+                $filename = basename($file);
+                if (isset($applied[$filename])) {
+                    continue;
+                }
+
+                $sql = file_get_contents($file);
+                if ($sql === false || trim($sql) === '') {
+                    fwrite(STDERR, sprintf("module-migrate: WARNING skipping empty file %s/%s\n", $manifest->id, $filename));
+                    continue;
+                }
+
+                fwrite(STDOUT, sprintf("module-migrate: applying %s/%s ... ", $manifest->id, $filename));
+
+                $this->repository->beginTransaction();
+                try {
+                    $statements = SqlStatementParser::splitStatements($sql);
+                    foreach ($statements as $statement) {
+                        $this->repository->executeStatement($statement);
+                    }
+
+                    $this->repository->recordApplied((string) $manifest->id, $filename);
+                    $this->repository->commit();
+                } catch (\Throwable $migrationError) {
+                    $this->repository->rollback();
+                    throw new RuntimeException(
+                        sprintf("Migration %s/%s failed: %s", $manifest->id, $filename, $migrationError->getMessage()),
+                        0,
+                        $migrationError
+                    );
+                }
+
+                fwrite(STDOUT, "OK\n");
+                $totalApplied++;
+            }
+        }
+
+        if ($totalApplied === 0) {
+            fwrite(STDOUT, "module-migrate: all modules up to date, 0 new migrations.\n");
+        } else {
+            fwrite(STDOUT, sprintf("module-migrate: applied %d migration(s).\n", $totalApplied));
+        }
+
+        return ['ok' => true, 'applied' => $totalApplied];
+    }
+}