fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(audit): extract audit domain into self-contained module

Browse Source 
Move the entire audit subsystem (system audit, API audit, import audit,
user lifecycle audit, frontend telemetry) from core into modules/audit/.

Core decoupling via interface-based injection:
- AuditRecorderInterface replaces SystemAuditService in 10+ core services
- UserLifecycleAuditInterface / ImportAuditInterface for specialized flows
- NullAuditRecorder fallback when audit module is disabled
- ApiBootstrap/ApiResponse use null-safe callable resolvers

Module structure (modules/audit/):
- Manifest with routes, permissions, scheduler jobs, authorization policy
- 9 services, 8 repositories, 6 domain enums, 4 job handlers
- 33 page files, 4 JS files, 8 test files, migration scripts, i18n

Core cleanup:
- OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService
  surgically cleaned of audit-specific constants
- Sidebar template cleared of hardcoded audit navigation
- AuditModuleIsolationContractTest ensures no future core→module coupling

All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5
clean, architecture contracts verified.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-03-25 21:12:49 +01:00
parent 12a837bda9
commit 0c351f6aff
176 changed files with 2157 additions and 834 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/Service/User/UserLifecycleServiceTest.php
View File

@@ -5,7 +5,7 @@ namespace MintyPHP\Tests\Service\User;
use MintyPHP\Repository\Support\DatabaseSessionRepository;
use MintyPHP\Repository\User\UserReadRepositoryInterface;
use MintyPHP\Repository\User\UserWriteRepositoryInterface;
use MintyPHP\Service\Audit\UserLifecycleAuditService;
use MintyPHP\Service\Audit\UserLifecycleAuditInterface;
use MintyPHP\Service\User\UserLifecycleService;
use MintyPHP\Service\User\UserSettingsGateway;
use PHPUnit\Framework\MockObject\MockObject;
@@ -16,7 +16,7 @@ class UserLifecycleServiceTest extends TestCase
private UserReadRepositoryInterface&MockObject $userReadRepository;
private UserWriteRepositoryInterface&MockObject $userWriteRepository;
private UserSettingsGateway&MockObject $settingsGateway;
private UserLifecycleAuditService&MockObject $auditService;
private UserLifecycleAuditInterface&MockObject $auditService;
private DatabaseSessionRepository&MockObject $databaseSessionRepository;
protected function setUp(): void
@@ -24,7 +24,7 @@ class UserLifecycleServiceTest extends TestCase
$this->userReadRepository = $this->createMock(UserReadRepositoryInterface::class);
$this->userWriteRepository = $this->createMock(UserWriteRepositoryInterface::class);
$this->settingsGateway = $this->createMock(UserSettingsGateway::class);
$this->auditService = $this->createMock(UserLifecycleAuditService::class);
$this->auditService = $this->createMock(UserLifecycleAuditInterface::class);
$this->databaseSessionRepository = $this->createMock(DatabaseSessionRepository::class);
// Default: lock succeeds, release is a no-op