fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(audit): extract audit domain into self-contained module

Browse Source 
Move the entire audit subsystem (system audit, API audit, import audit,
user lifecycle audit, frontend telemetry) from core into modules/audit/.

Core decoupling via interface-based injection:
- AuditRecorderInterface replaces SystemAuditService in 10+ core services
- UserLifecycleAuditInterface / ImportAuditInterface for specialized flows
- NullAuditRecorder fallback when audit module is disabled
- ApiBootstrap/ApiResponse use null-safe callable resolvers

Module structure (modules/audit/):
- Manifest with routes, permissions, scheduler jobs, authorization policy
- 9 services, 8 repositories, 6 domain enums, 4 job handlers
- 33 page files, 4 JS files, 8 test files, migration scripts, i18n

Core cleanup:
- OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService
  surgically cleaned of audit-specific constants
- Sidebar template cleared of hardcoded audit navigation
- AuditModuleIsolationContractTest ensures no future core→module coupling

All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5
clean, architecture contracts verified.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-03-25 21:12:49 +01:00
parent 12a837bda9
commit 0c351f6aff
176 changed files with 2157 additions and 834 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/Service/User/UserAccountServiceTest.php
View File

@@ -6,7 +6,7 @@ use MintyPHP\Repository\Support\DatabaseSessionRepository;
use MintyPHP\Repository\User\UserListQueryRepositoryInterface;
use MintyPHP\Repository\User\UserReadRepositoryInterface;
use MintyPHP\Repository\User\UserWriteRepositoryInterface;
use MintyPHP\Service\Audit\SystemAuditService;
use MintyPHP\Service\Audit\AuditRecorderInterface;
use MintyPHP\Service\Tenant\TenantScopeService;
use MintyPHP\Service\User\UserAccountService;
use MintyPHP\Service\User\UserAssignmentService;
@@ -96,7 +96,7 @@ class UserAccountServiceTest extends TestCase
->with(11)
->willReturn(true);
$auditService = $this->createMock(SystemAuditService::class);
$auditService = $this->createMock(AuditRecorderInterface::class);
$auditService->expects($this->once())
->method('record')
->with(
@@ -130,7 +130,7 @@ class UserAccountServiceTest extends TestCase
->with(11)
->willReturn(false);
$auditService = $this->createMock(SystemAuditService::class);
$auditService = $this->createMock(AuditRecorderInterface::class);
$auditService->expects($this->never())->method('record');
$service = $this->newService($readRepository, $writeRepository, null, null, null, null, null, null, $auditService);
@@ -230,7 +230,7 @@ class UserAccountServiceTest extends TestCase
$assignmentService = $this->createMock(UserAssignmentService::class);
$assignmentService->expects($this->never())->method('bumpAuthzVersion');
$auditService = $this->createMock(SystemAuditService::class);
$auditService = $this->createMock(AuditRecorderInterface::class);
$auditService->expects($this->never())->method('record');
$service = $this->newService($readRepository, $writeRepository, null, $assignmentService, null, null, null, null, $auditService);
@@ -257,7 +257,7 @@ class UserAccountServiceTest extends TestCase
->method('bumpAuthzVersion')
->with(33);
$auditService = $this->createMock(SystemAuditService::class);
$auditService = $this->createMock(AuditRecorderInterface::class);
$auditService->expects($this->once())
->method('record')
->with(
@@ -293,7 +293,7 @@ class UserAccountServiceTest extends TestCase
$scopeGateway = $this->createMock(TenantScopeService::class);
$scopeGateway->method('canAccess')->willReturn(true);
$auditService = $this->createMock(SystemAuditService::class);
$auditService = $this->createMock(AuditRecorderInterface::class);
$auditService->expects($this->once())
->method('record')
->with(
@@ -398,7 +398,7 @@ class UserAccountServiceTest extends TestCase
$assignmentService->expects($this->never())->method('syncRoles');
$assignmentService->expects($this->never())->method('syncDepartments');
$auditService = $this->createMock(SystemAuditService::class);
$auditService = $this->createMock(AuditRecorderInterface::class);
$auditService->expects($this->never())->method('record');
$databaseSessionRepository = $this->createMock(DatabaseSessionRepository::class);
@@ -628,7 +628,7 @@ class UserAccountServiceTest extends TestCase
?UserSettingsGateway $settingsGateway = null,
?TenantScopeService $scopeGateway = null,
?UserDirectoryGateway $directoryGateway = null,
?SystemAuditService $auditService = null,
?AuditRecorderInterface $auditService = null,
?DatabaseSessionRepository $databaseSessionRepository = null
): UserAccountService {
$readRepository = $readRepository ?? $this->createMock(UserReadRepositoryInterface::class);
@@ -673,7 +673,7 @@ class UserAccountServiceTest extends TestCase
$directoryGateway->method('findTenantByUuid')->willReturn(null);
}
$auditService = $auditService ?? $this->createMock(SystemAuditService::class);
$auditService = $auditService ?? $this->createMock(AuditRecorderInterface::class);
$databaseSessionRepository = $databaseSessionRepository ?? $this->createMock(DatabaseSessionRepository::class);
return new UserAccountService(