fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(audit): extract audit domain into self-contained module

Browse Source 
Move the entire audit subsystem (system audit, API audit, import audit,
user lifecycle audit, frontend telemetry) from core into modules/audit/.

Core decoupling via interface-based injection:
- AuditRecorderInterface replaces SystemAuditService in 10+ core services
- UserLifecycleAuditInterface / ImportAuditInterface for specialized flows
- NullAuditRecorder fallback when audit module is disabled
- ApiBootstrap/ApiResponse use null-safe callable resolvers

Module structure (modules/audit/):
- Manifest with routes, permissions, scheduler jobs, authorization policy
- 9 services, 8 repositories, 6 domain enums, 4 job handlers
- 33 page files, 4 JS files, 8 test files, migration scripts, i18n

Core cleanup:
- OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService
  surgically cleaned of audit-specific constants
- Sidebar template cleared of hardcoded audit navigation
- AuditModuleIsolationContractTest ensures no future core→module coupling

All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5
clean, architecture contracts verified.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-03-25 21:12:49 +01:00
parent 12a837bda9
commit 0c351f6aff
176 changed files with 2157 additions and 834 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
tests/Architecture/StatusTaxonomyContractFiles.php
View File

@@ -10,12 +10,12 @@ final class StatusTaxonomyContractFiles
public static function taxonomyEnumFiles(): array
{
return [
'lib/Domain/Taxonomy/SystemAuditOutcome.php',
'lib/Domain/Taxonomy/SystemAuditChannel.php',
'lib/Domain/Taxonomy/UserLifecycleAction.php',
'lib/Domain/Taxonomy/UserLifecycleTriggerType.php',
'lib/Domain/Taxonomy/UserLifecycleStatus.php',
'lib/Domain/Taxonomy/ImportAuditStatus.php',
'modules/audit/lib/Module/Audit/Domain/SystemAuditOutcome.php',
'modules/audit/lib/Module/Audit/Domain/SystemAuditChannel.php',
'modules/audit/lib/Module/Audit/Domain/UserLifecycleAction.php',
'modules/audit/lib/Module/Audit/Domain/UserLifecycleTriggerType.php',
'modules/audit/lib/Module/Audit/Domain/UserLifecycleStatus.php',
'modules/audit/lib/Module/Audit/Domain/ImportAuditStatus.php',
'lib/Domain/Taxonomy/ScheduledJobStatus.php',
'lib/Domain/Taxonomy/ScheduledJobRunStatus.php',
'lib/Domain/Taxonomy/ScheduledJobTriggerType.php',
@@ -31,16 +31,16 @@ final class StatusTaxonomyContractFiles
public static function taxonomySchemaExpectations(): array
{
return [
'pages/admin/system-audit/filter-schema.php' => [
'modules/audit/pages/admin/system-audit/filter-schema.php' => [
'SystemAuditOutcome::values()',
'SystemAuditChannel::values()',
],
'pages/admin/user-lifecycle-audit/filter-schema.php' => [
'modules/audit/pages/admin/user-lifecycle-audit/filter-schema.php' => [
'gridEnumSanitizer(UserLifecycleAction::class)',
'gridEnumSanitizer(UserLifecycleStatus::class)',
'gridEnumSanitizer(UserLifecycleTriggerType::class)',
],
'pages/admin/import-audit/filter-schema.php' => [
'modules/audit/pages/admin/import-audit/filter-schema.php' => [
'ImportAuditStatus::values()',
],
'pages/admin/scheduled-jobs/filter-schema.php' => [
@@ -62,9 +62,9 @@ final class StatusTaxonomyContractFiles
public static function taxonomyDataEndpointFiles(): array
{
return [
'pages/admin/system-audit/data().php',
'pages/admin/user-lifecycle-audit/data().php',
'pages/admin/import-audit/data().php',
'modules/audit/pages/admin/system-audit/data().php',
'modules/audit/pages/admin/user-lifecycle-audit/data().php',
'modules/audit/pages/admin/import-audit/data().php',
'pages/admin/scheduled-jobs/data().php',
'pages/admin/scheduled-jobs/runs-data($id).php',
'pages/admin/mail-log/data().php',
@@ -78,13 +78,13 @@ final class StatusTaxonomyContractFiles
public static function taxonomyLiteralGuardFiles(): array
{
return [
'lib/Service/Audit/SystemAuditService.php',
'lib/Repository/Audit/SystemAuditLogRepository.php',
'lib/Http/ApiSystemAuditReporter.php',
'lib/Service/Audit/UserLifecycleAuditService.php',
'lib/Repository/Audit/UserLifecycleAuditRepository.php',
'lib/Service/Audit/ImportAuditService.php',
'lib/Repository/Audit/ImportAuditRunRepository.php',
'modules/audit/lib/Module/Audit/Service/SystemAuditService.php',
'modules/audit/lib/Module/Audit/Repository/SystemAuditLogRepository.php',
'modules/audit/lib/Module/Audit/Http/ApiSystemAuditReporter.php',
'modules/audit/lib/Module/Audit/Service/UserLifecycleAuditService.php',
'modules/audit/lib/Module/Audit/Repository/UserLifecycleAuditRepository.php',
'modules/audit/lib/Module/Audit/Service/ImportAuditService.php',
'modules/audit/lib/Module/Audit/Repository/ImportAuditRunRepository.php',
'lib/Service/Scheduler/SchedulerRunService.php',
'lib/Repository/Scheduler/ScheduledJobRepository.php',
'lib/Repository/Scheduler/ScheduledJobRunRepository.php',
@@ -94,16 +94,16 @@ final class StatusTaxonomyContractFiles
'lib/Service/Tenant/TenantService.php',
'lib/Repository/Tenant/TenantRepository.php',
'lib/Repository/Stats/AdminStatsRepository.php',
'pages/admin/system-audit/data().php',
'pages/admin/user-lifecycle-audit/data().php',
'pages/admin/import-audit/data().php',
'modules/audit/pages/admin/system-audit/data().php',
'modules/audit/pages/admin/user-lifecycle-audit/data().php',
'modules/audit/pages/admin/import-audit/data().php',
'pages/admin/scheduled-jobs/data().php',
'pages/admin/scheduled-jobs/runs-data($id).php',
'pages/admin/mail-log/data().php',
'pages/admin/tenants/data().php',
'pages/admin/system-audit/index().php',
'pages/admin/user-lifecycle-audit/index().php',
'pages/admin/import-audit/index().php',
'modules/audit/pages/admin/system-audit/index().php',
'modules/audit/pages/admin/user-lifecycle-audit/index().php',
'modules/audit/pages/admin/import-audit/index().php',
'pages/admin/scheduled-jobs/index().php',
'pages/admin/mail-log/index().php',
];