refactor(audit): extract audit domain into self-contained module

Move the entire audit subsystem (system audit, API audit, import audit, user lifecycle audit, frontend telemetry) from core into modules/audit/. Core decoupling via interface-based injection: - AuditRecorderInterface replaces SystemAuditService in 10+ core services - UserLifecycleAuditInterface / ImportAuditInterface for specialized flows - NullAuditRecorder fallback when audit module is disabled - ApiBootstrap/ApiResponse use null-safe callable resolvers Module structure (modules/audit/): - Manifest with routes, permissions, scheduler jobs, authorization policy - 9 services, 8 repositories, 6 domain enums, 4 job handlers - 33 page files, 4 JS files, 8 test files, migration scripts, i18n Core cleanup: - OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService surgically cleaned of audit-specific constants - Sidebar template cleared of hardcoded audit navigation - AuditModuleIsolationContractTest ensures no future core→module coupling All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5 clean, architecture contracts verified. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-25 21:12:49 +01:00
parent 12a837bda9
commit 0c351f6aff
176 changed files with 2157 additions and 834 deletions
--- a/tests/Architecture/AuditModuleIsolationContractTest.php
+++ b/tests/Architecture/AuditModuleIsolationContractTest.php
@@ -0,0 +1,115 @@
+<?php
+
+namespace MintyPHP\Tests\Architecture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AuditModuleIsolationContractTest extends TestCase
+{
+    public function testCoreServiceAuditDirectoryContainsOnlyInterfaces(): void
+    {
+        $dir = dirname(__DIR__, 2) . '/lib/Service/Audit';
+        self::assertDirectoryExists($dir);
+
+        $files = array_values(array_filter(
+            scandir($dir) ?: [],
+            static fn (string $f): bool => str_ends_with($f, '.php')
+        ));
+
+        $allowed = [
+            'AuditRecorderInterface.php',
+            'ImportAuditInterface.php',
+            'NullAuditRecorder.php',
+            'NullImportAudit.php',
+            'NullUserLifecycleAudit.php',
+            'UserLifecycleAuditInterface.php',
+        ];
+
+        sort($files);
+        sort($allowed);
+
+        self::assertSame(
+            $allowed,
+            $files,
+            'lib/Service/Audit/ should contain only interfaces and null implementations, found: ' . implode(', ', $files)
+        );
+    }
+
+    public function testCoreRepositoryAuditDirectoryDoesNotExist(): void
+    {
+        $root = dirname(__DIR__, 2);
+        self::assertDirectoryDoesNotExist(
+            $root . '/lib/Repository/Audit',
+            'Audit repository classes should live in modules/audit/lib, not in Core lib/Repository/Audit'
+        );
+    }
+
+    public function testCoreDomainTaxonomyHasNoAuditEnums(): void
+    {
+        $dir = dirname(__DIR__, 2) . '/lib/Domain/Taxonomy';
+        if (!is_dir($dir)) {
+            self::addToAssertionCount(1);
+            return;
+        }
+
+        $entries = scandir($dir) ?: [];
+        $auditFiles = array_filter($entries, static fn (string $f): bool => str_contains($f, 'Audit') || str_contains($f, 'Lifecycle'));
+        self::assertSame(
+            [],
+            array_values($auditFiles),
+            'Core lib/Domain/Taxonomy/ still contains audit enum files: ' . implode(', ', $auditFiles)
+        );
+    }
+
+    public function testCoreAuditPagesRemoved(): void
+    {
+        $root = dirname(__DIR__, 2);
+        self::assertDirectoryDoesNotExist($root . '/pages/admin/api-audit');
+        self::assertDirectoryDoesNotExist($root . '/pages/admin/system-audit');
+        self::assertDirectoryDoesNotExist($root . '/pages/admin/import-audit');
+        self::assertDirectoryDoesNotExist($root . '/pages/admin/user-lifecycle-audit');
+        self::assertDirectoryDoesNotExist($root . '/pages/admin/frontend-telemetry');
+    }
+
+    public function testCoreJsHasNoAuditPageScripts(): void
+    {
+        $root = dirname(__DIR__, 2);
+        self::assertFileDoesNotExist($root . '/web/js/pages/admin-api-audit-index.js');
+        self::assertFileDoesNotExist($root . '/web/js/pages/admin-system-audit-index.js');
+        self::assertFileDoesNotExist($root . '/web/js/pages/admin-import-audit-index.js');
+        self::assertFileDoesNotExist($root . '/web/js/pages/admin-user-lifecycle-audit-index.js');
+    }
+
+    public function testCoreHttpHasNoConcreteAuditReporter(): void
+    {
+        $root = dirname(__DIR__, 2);
+        self::assertFileDoesNotExist(
+            $root . '/lib/Http/ApiSystemAuditReporter.php',
+            'ApiSystemAuditReporter should live in modules/audit/lib, not in Core lib/Http'
+        );
+    }
+
+    public function testCoreSidebarHasNoHardcodedAuditNavigation(): void
+    {
+        $file = dirname(__DIR__, 2) . '/templates/partials/app-main-aside.phtml';
+        $content = file_get_contents($file);
+        self::assertIsString($content);
+        self::assertStringNotContainsString('can_view_api_audit', $content);
+        self::assertStringNotContainsString('can_view_system_audit', $content);
+        self::assertStringNotContainsString('can_view_imports_audit', $content);
+        self::assertStringNotContainsString('can_view_user_lifecycle_audit', $content);
+        self::assertStringNotContainsString('admin/api-audit', $content);
+        self::assertStringNotContainsString('admin/system-audit', $content);
+        self::assertStringNotContainsString('admin/import-audit', $content);
+        self::assertStringNotContainsString('admin/user-lifecycle-audit', $content);
+    }
+
+    public function testCoreSchedulerHandlerRemoved(): void
+    {
+        $root = dirname(__DIR__, 2);
+        self::assertFileDoesNotExist(
+            $root . '/lib/Service/Scheduler/Handler/SystemAuditPurgeJobHandler.php',
+            'SystemAuditPurgeJobHandler should live in modules/audit, not in Core'
+        );
+    }
+}