refactor(actions): deduplicate audit metadata and grid user count enrichment

This commit is contained in:
2026-03-13 12:05:11 +01:00
parent 892da0048d
commit 010690de19
17 changed files with 638 additions and 143 deletions

View File

@@ -15,10 +15,12 @@ use MintyPHP\Http\SessionStoreInterface;
use MintyPHP\Repository\Search\SearchQueryRepository;
use MintyPHP\Repository\Stats\AdminStatsRepository;
use MintyPHP\Repository\Tenant\UserTenantRepository;
use MintyPHP\Repository\User\UserReadRepository;
use MintyPHP\Service\Access\PermissionService;
use MintyPHP\Service\AddressBook\AddressBookService;
use MintyPHP\Service\AddressBook\AddressBookServicesFactory;
use MintyPHP\Service\Audit\ApiAuditService;
use MintyPHP\Service\Audit\AuditMetadataEnricher;
use MintyPHP\Service\Audit\AuditServicesFactory;
use MintyPHP\Service\Audit\FrontendTelemetryIngestService;
use MintyPHP\Service\Audit\ImportAuditService;
@@ -27,6 +29,7 @@ use MintyPHP\Service\Audit\UserLifecycleAuditService;
use MintyPHP\Service\CustomField\CustomFieldServicesFactory;
use MintyPHP\Service\CustomField\TenantCustomFieldService;
use MintyPHP\Service\CustomField\UserCustomFieldValueService;
use MintyPHP\Service\Data\GridUserCountEnricher;
use MintyPHP\Service\Import\ImportService;
use MintyPHP\Service\Import\ImportServicesFactory;
use MintyPHP\Service\Mail\MailLogService;
@@ -75,6 +78,10 @@ final class AppServicesRegistrar implements ContainerRegistrar
$container->set(AddressBookService::class, static fn (AppContainer $c): AddressBookService => $c->get(AddressBookServicesFactory::class)->createAddressBookService());
$container->set(TenantCustomFieldService::class, static fn (AppContainer $c): TenantCustomFieldService => $c->get(CustomFieldServicesFactory::class)->createTenantCustomFieldService());
$container->set(UserCustomFieldValueService::class, static fn (AppContainer $c): UserCustomFieldValueService => $c->get(CustomFieldServicesFactory::class)->createUserCustomFieldValueService());
$container->set(AuditMetadataEnricher::class, static fn (AppContainer $c): AuditMetadataEnricher => new AuditMetadataEnricher(
$c->get(UserReadRepository::class)
));
$container->set(GridUserCountEnricher::class, static fn (): GridUserCountEnricher => new GridUserCountEnricher());
$container->set(RequestInputFactory::class, static fn (): RequestInputFactory => new RequestInputFactory());
$container->set(SessionStore::class, static fn (): SessionStore => new SessionStore());
$container->set(SessionStoreInterface::class, static fn (AppContainer $c): SessionStoreInterface => $c->get(SessionStore::class));

View File

@@ -0,0 +1,42 @@
<?php
namespace MintyPHP\Service\Audit;
use MintyPHP\Repository\User\UserReadRepositoryInterface;
class AuditMetadataEnricher
{
public function __construct(
private readonly UserReadRepositoryInterface $userReadRepository
) {
}
/**
* Resolve audit user IDs on an entity into display labels and UUIDs.
*
* For each field name in $fields the method reads `$entity[$field]` as a
* user ID, looks up the user record, and sets `{$field}_label` (full name
* with email fallback) and `{$field}_uuid` on the entity.
*
* @param array<string,mixed> $entity The entity array (modified in place).
* @param list<string> $fields Audit field names to resolve (e.g. 'created_by', 'modified_by').
*/
public function enrich(array &$entity, array $fields = ['created_by', 'modified_by']): void
{
foreach ($fields as $field) {
$userId = (int) ($entity[$field] ?? 0);
if ($userId <= 0) {
continue;
}
$user = $this->userReadRepository->find($userId);
if (!$user) {
continue;
}
$name = trim(($user['first_name'] ?? '') . ' ' . ($user['last_name'] ?? ''));
$entity[$field . '_label'] = $name !== '' ? $name : ($user['email'] ?? '');
$entity[$field . '_uuid'] = $user['uuid'] ?? null;
}
}
}

View File

@@ -0,0 +1,46 @@
<?php
namespace MintyPHP\Service\Data;
class GridUserCountEnricher
{
/**
* Collect entity IDs from grid rows, batch-query total and active user
* counts, and return a lookup map keyed by entity ID.
*
* @param array[] $rows Grid result rows (each must have an 'id' key).
* @param callable(list<int>): array<int,int> $countTotal fn(ids) => [entityId => totalCount]
* @param callable(list<int>): array<int,int> $countActive fn(ids) => [entityId => activeCount]
* @return array<int, array{active_users: int, inactive_users: int}>
*/
public function computeCounts(array $rows, callable $countTotal, callable $countActive): array
{
$ids = [];
foreach ($rows as $row) {
$id = (int) ($row['id'] ?? 0);
if ($id > 0) {
$ids[] = $id;
}
}
$ids = array_values(array_unique($ids));
if (!$ids) {
return [];
}
$totalCounts = $countTotal($ids);
$activeCounts = $countActive($ids);
$result = [];
foreach ($ids as $id) {
$total = (int) ($totalCounts[$id] ?? 0);
$active = (int) ($activeCounts[$id] ?? 0);
$result[$id] = [
'active_users' => $active,
'inactive_users' => max(0, $total - $active),
];
}
return $result;
}
}