37 lines
2.1 KiB
JSON
37 lines
2.1 KiB
JSON
|
{
|
||
|
|
"task_id": "CODE-DEDUP-REPOSITORY-001",
|
||
|
|
"verdict": "pass",
|
||
|
|
"checked_criterion_ids": [
|
||
|
|
"SC-001",
|
||
|
|
"SC-002",
|
||
|
|
"SC-003",
|
||
|
|
"SC-004"
|
||
|
|
],
|
||
|
|
"checks": [
|
||
|
|
{
|
||
|
|
"criterion_id": "SC-001",
|
||
|
|
"criterion": "A single RepositoryArrayHelper class exists in lib/Repository/Support/ providing extractIds(), sanitizePositiveIds(), unwrap(), and unwrapList() as static methods.",
|
||
|
|
"result": "pass",
|
||
|
|
"evidence": "execution-report.changed_files lists lib/Repository/Support/RepositoryArrayHelper.php as created with all four static methods; execution-report.commands includes the SC-001+SC-002 RepositoryArrayHelper usage check with result pass."
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"criterion_id": "SC-002",
|
||
|
|
"criterion": "All 6+ repository files use RepositoryArrayHelper instead of inline implementations. No duplicate unwrap/extractIds/sanitize logic remains.",
|
||
|
|
"result": "pass",
|
||
|
|
"evidence": "execution-report.changed_files lists 6 repository refactors (Tenant, Role, Permission, Department, UserDepartment, UserRole) and removal/replacement of inline helper logic; execution-report.commands includes pass results for RepositoryArrayHelper usage and private unwrap duplication checks."
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"criterion_id": "SC-003",
|
||
|
|
"criterion": "Repository public method signatures and return values are identical before and after refactoring (pure internal refactor).",
|
||
|
|
"result": "pass",
|
||
|
|
"evidence": "execution-report.guard_evidence for GR-CORE-001 states unchanged public API across refactored repositories, and changed_files summaries describe internal helper replacement/removal of private methods only."
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"criterion_id": "SC-004",
|
||
|
|
"criterion": "PHPUnit, PHPStan, Architecture Contract, and CS checks pass green; zero new failures introduced by this task (pre-existing failures are out of scope).",
|
||
|
|
"result": "pass",
|
||
|
|
"evidence": "execution-report.quality_gate_results marks QG-001, QG-002, QG-003, and QG-006 as pass; execution-report.commands records all corresponding commands as pass; notes classify remaining issues as pre-existing and not introduced by this task."
|
||
|
|
}
|
||
|
|
]
|
||
|
|
}
|