2026-03-04 15:56:58 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
|
|
|
|
|
|
use PHPUnit\Framework\Attributes\DataProvider;
|
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
|
use ReflectionClass;
|
|
|
|
|
use ReflectionMethod;
|
|
|
|
|
|
|
|
|
|
class ContainerFactoryContractTest extends TestCase
|
|
|
|
|
{
|
|
|
|
|
/**
|
|
|
|
|
* @return array<int, array{0: class-string}>
|
|
|
|
|
*/
|
|
|
|
|
public static function factoryClassProvider(): array
|
|
|
|
|
{
|
|
|
|
|
return [
|
|
|
|
|
[\MintyPHP\Service\Access\AccessServicesFactory::class],
|
feat: extend module platform with UI slots, runtime components, CLI tooling and {{userId}} search support
Completes the generic module platform that enables modules to contribute
UI elements, runtime JS components, and search resources without any
core hardcoding.
New generic UI slot types:
- topbar.right_item: module-contributed topbar buttons
- layout.body_end_template: module-contributed dialog/overlay templates
- layout.head_style: module-contributed global CSS
- runtime.component: declarative JS component registration with phase ordering
New infrastructure:
- ModuleAutoloader: PSR-4 autoloading for module-local PHP classes
- ModuleRuntimePageBuilder: symlinks module pages into runtime directory
- ModuleRuntimeAssetPublisher: publishes module CSS/JS to web/modules/
- ModulePermissionSynchronizer: syncs module permissions to DB
- CLI scripts: module-runtime-sync, module-build, module-migrate,
module-permissions-sync, module-assets-sync
- {{userId}} placeholder in SearchDataService for user-scoped search queries
- Component runtime with phased initialization (early/default/late)
- AppContainer.protectExistingBindings() to prevent module→core overwrites
- Architecture tests: ModuleStructureContractTest, CoreTemplateIsolationTest,
FrontendComponentRuntimeContractTest, AppContainerIsolationContractTest
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-18 22:19:56 +01:00
|
|
|
[\MintyPHP\Module\AddressBook\Service\AddressBookServicesFactory::class],
|
refactor(audit): extract audit domain into self-contained module
Move the entire audit subsystem (system audit, API audit, import audit,
user lifecycle audit, frontend telemetry) from core into modules/audit/.
Core decoupling via interface-based injection:
- AuditRecorderInterface replaces SystemAuditService in 10+ core services
- UserLifecycleAuditInterface / ImportAuditInterface for specialized flows
- NullAuditRecorder fallback when audit module is disabled
- ApiBootstrap/ApiResponse use null-safe callable resolvers
Module structure (modules/audit/):
- Manifest with routes, permissions, scheduler jobs, authorization policy
- 9 services, 8 repositories, 6 domain enums, 4 job handlers
- 33 page files, 4 JS files, 8 test files, migration scripts, i18n
Core cleanup:
- OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService
surgically cleaned of audit-specific constants
- Sidebar template cleared of hardcoded audit navigation
- AuditModuleIsolationContractTest ensures no future core→module coupling
All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5
clean, architecture contracts verified.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-25 21:12:49 +01:00
|
|
|
[\MintyPHP\Module\Audit\Service\AuditServicesFactory::class],
|
2026-03-04 15:56:58 +01:00
|
|
|
[\MintyPHP\Service\Auth\AuthServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\Branding\BrandingServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\Directory\DirectoryServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\Import\ImportServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\Mail\MailServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\Scheduler\SchedulerServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\Security\SecurityServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\Settings\SettingServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\Tenant\TenantServicesFactory::class],
|
|
|
|
|
[\MintyPHP\Service\User\UserServicesFactory::class],
|
|
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[DataProvider('factoryClassProvider')]
|
|
|
|
|
public function testContainerFactoriesCachePublicNoArgCreateMethods(string $factoryClass): void
|
|
|
|
|
{
|
|
|
|
|
$factory = app($factoryClass);
|
|
|
|
|
$this->assertInstanceOf($factoryClass, $factory);
|
|
|
|
|
|
|
|
|
|
$reflection = new ReflectionClass($factoryClass);
|
|
|
|
|
$methods = array_filter(
|
|
|
|
|
$reflection->getMethods(ReflectionMethod::IS_PUBLIC),
|
|
|
|
|
static fn (ReflectionMethod $method): bool =>
|
|
|
|
|
!$method->isStatic()
|
|
|
|
|
&& str_starts_with($method->getName(), 'create')
|
|
|
|
|
&& $method->getNumberOfRequiredParameters() === 0
|
|
|
|
|
);
|
|
|
|
|
usort($methods, static fn (ReflectionMethod $a, ReflectionMethod $b): int => strcmp($a->getName(), $b->getName()));
|
|
|
|
|
|
|
|
|
|
foreach ($methods as $method) {
|
|
|
|
|
$methodName = $method->getName();
|
|
|
|
|
$first = $factory->{$methodName}();
|
|
|
|
|
$second = $factory->{$methodName}();
|
|
|
|
|
|
|
|
|
|
$this->assertIsObject($first, sprintf('%s::%s() must return an object', $factoryClass, $methodName));
|
|
|
|
|
$this->assertInstanceOf($first::class, $second, sprintf('%s::%s() must be type-stable', $factoryClass, $methodName));
|
|
|
|
|
$this->assertSame($first, $second, sprintf('%s::%s() must return the cached instance', $factoryClass, $methodName));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|