2026-03-19 18:25:19 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
|
|
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
|
|
|
|
|
|
class AuthzUiLayoutContractTest extends TestCase
|
|
|
|
|
{
|
|
|
|
|
use ProjectFileAssertionSupport;
|
|
|
|
|
|
|
|
|
|
public function testLayoutPartialsUseViewAuthLayoutCapabilities(): void
|
|
|
|
|
{
|
|
|
|
|
$defaultTemplate = $this->readProjectFile('templates/default.phtml');
|
|
|
|
|
$this->assertStringContainsString("\$viewAuth['layout']", $defaultTemplate);
|
|
|
|
|
$this->assertStringNotContainsString('UiAccessService::class', $defaultTemplate);
|
|
|
|
|
|
|
|
|
|
$aside = $this->readProjectFile('templates/partials/app-main-aside.phtml');
|
|
|
|
|
$this->assertStringContainsString("\$viewAuth['layout']", $aside);
|
|
|
|
|
$this->assertStringContainsString('layoutHasAdminPanel(', $aside);
|
|
|
|
|
$this->assertStringContainsString('$layoutNav', $aside);
|
|
|
|
|
|
|
|
|
|
$iconBar = $this->readProjectFile('templates/partials/app-main-aside-icon-bar.phtml');
|
|
|
|
|
$this->assertStringContainsString("\$viewAuth['layout']", $iconBar);
|
|
|
|
|
$this->assertStringContainsString('layoutHasAdminPanel(', $iconBar);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testAsideTemplateDoesNotReadRequestOrResolveServicesDirectly(): void
|
|
|
|
|
{
|
|
|
|
|
$aside = $this->readProjectFile('templates/partials/app-main-aside.phtml');
|
|
|
|
|
|
|
|
|
|
$this->assertStringNotContainsString('$_GET', $aside);
|
|
|
|
|
$this->assertStringNotContainsString('$_SESSION', $aside);
|
feat(tenant): per-theme logos + file-upload + button UI polish
Replace the single tenant avatar with a pair of theme-scoped brand logos.
Render only the theme-matching <img> server-side and swap src on theme
toggle via a JS hook — no reload, no double request, no CSS tricks.
Tenant logos
- TenantLogoService (ImageUploadTrait) with theme whitelist and per-theme
storage storage/tenants/{uuid}/logo/{light|dark}/, SIZES 128/256/512
- Public serving endpoint auth/tenant-logo-file so login can show the
logo pre-auth; matching authenticated admin preview endpoint
- appTenantLogoUrl(?size, ?theme) with 4-step fallback cascade; PDF +
mail always request 'light'
- Admin tenant edit: avatar block replaced by "Tenant logos" details
block inside the Master-data tab, two side-by-side slots via Pico
.grid with the core app-file-upload partial
- Policy rename ABILITY_ADMIN_TENANTS_AVATAR_VIEW -> LOGO_VIEW, action
routes logo / logo-delete / logo-file with theme body/query param
- API endpoint path kept (backward compat), internals on new service
- CLI tenant:logo-migrate-avatars moves legacy avatar/ -> logo/light/
idempotently (--dry-run, --yes, --cleanup)
- i18n "Tenant image" removed, 12 new keys synced across de/en
File upload component
- Full-width preview + filename/actions below (3D stack layout)
- Fixed 16:9 aspect ratio with 1rem inner padding for consistent
preview size across any logo aspect
- Transparency checker pattern as background so black logos stay
visible on dark mode and white logos on light mode
- form="" + deleteFormId support so the partial works with barrier
forms inside another form
Buttons
- width:100% dropped from button[type="submit"]; scoped back via
.login-main for the auth-flow primary CTA
- .outline base rule now tints background via color-mix of --app-color
so secondary/primary/danger outlines all gain a subtle surface
- .outline.secondary restyled Stripe-style in both themes: solid white
chip with soft shadow in light, solid elevated dark chip with white
text in dark; neutral border replaces role-colored border
- .app-action-success/.app-action-danger outlines get color-mix bg +
theme-aware outline-text tokens for stronger contrast
- Filled .primary/.app-action-success/.app-action-danger get raised
box-shadow (inset highlight + drop) — opt-in via class so chrome
buttons stay flat
- Dropped the legacy .secondary utility that was clobbering the
custom-property cascade with a hardcoded muted color
Theme swap
- Logo img carries data-src-light + data-src-dark; theme-toggle JS
swaps src when data-theme changes, keeping the topbar/login logo in
sync without a page reload
Quality gates: PHPUnit (2045), PHPStan L5, CS-Fixer, docs link/drift,
codex skills sync — all green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 20:25:53 +02:00
|
|
|
$this->assertStringNotContainsString('TenantLogoService', $aside);
|
2026-03-19 18:25:19 +01:00
|
|
|
$this->assertStringNotContainsString('app(', $aside);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testUiAccessServiceUsesCentralLayoutMapDefinition(): void
|
|
|
|
|
{
|
2026-04-13 23:20:05 +02:00
|
|
|
$content = $this->readProjectFile('core/Service/Access/UiAccessService.php');
|
2026-03-19 18:25:19 +01:00
|
|
|
$this->assertStringContainsString('UiCapabilityMap::LAYOUT', $content);
|
|
|
|
|
}
|
|
|
|
|
|
refactor(audit): extract audit domain into self-contained module
Move the entire audit subsystem (system audit, API audit, import audit,
user lifecycle audit, frontend telemetry) from core into modules/audit/.
Core decoupling via interface-based injection:
- AuditRecorderInterface replaces SystemAuditService in 10+ core services
- UserLifecycleAuditInterface / ImportAuditInterface for specialized flows
- NullAuditRecorder fallback when audit module is disabled
- ApiBootstrap/ApiResponse use null-safe callable resolvers
Module structure (modules/audit/):
- Manifest with routes, permissions, scheduler jobs, authorization policy
- 9 services, 8 repositories, 6 domain enums, 4 job handlers
- 33 page files, 4 JS files, 8 test files, migration scripts, i18n
Core cleanup:
- OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService
surgically cleaned of audit-specific constants
- Sidebar template cleared of hardcoded audit navigation
- AuditModuleIsolationContractTest ensures no future core→module coupling
All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5
clean, architecture contracts verified.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-25 21:12:49 +01:00
|
|
|
public function testCoreCapabilityMapDoesNotHardcodeAuditCapabilities(): void
|
2026-03-19 18:25:19 +01:00
|
|
|
{
|
2026-04-13 23:20:05 +02:00
|
|
|
$content = $this->readProjectFile('core/Service/Access/UiCapabilityMap.php');
|
refactor(audit): extract audit domain into self-contained module
Move the entire audit subsystem (system audit, API audit, import audit,
user lifecycle audit, frontend telemetry) from core into modules/audit/.
Core decoupling via interface-based injection:
- AuditRecorderInterface replaces SystemAuditService in 10+ core services
- UserLifecycleAuditInterface / ImportAuditInterface for specialized flows
- NullAuditRecorder fallback when audit module is disabled
- ApiBootstrap/ApiResponse use null-safe callable resolvers
Module structure (modules/audit/):
- Manifest with routes, permissions, scheduler jobs, authorization policy
- 9 services, 8 repositories, 6 domain enums, 4 job handlers
- 33 page files, 4 JS files, 8 test files, migration scripts, i18n
Core cleanup:
- OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService
surgically cleaned of audit-specific constants
- Sidebar template cleared of hardcoded audit navigation
- AuditModuleIsolationContractTest ensures no future core→module coupling
All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5
clean, architecture contracts verified.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-25 21:12:49 +01:00
|
|
|
$this->assertStringNotContainsString('can_view_system_audit', $content);
|
|
|
|
|
$this->assertStringNotContainsString('can_view_api_audit', $content);
|
|
|
|
|
$this->assertStringNotContainsString('can_view_user_lifecycle_audit', $content);
|
|
|
|
|
$this->assertStringNotContainsString('can_view_imports_audit', $content);
|
2026-03-19 18:25:19 +01:00
|
|
|
}
|
|
|
|
|
}
|