2026-02-24 08:49:40 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MintyPHP\Tests\Service\Access;
|
|
|
|
|
|
|
|
|
|
use MintyPHP\Service\Access\PermissionService;
|
|
|
|
|
use MintyPHP\Service\Access\SettingsAuthorizationPolicy;
|
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
|
|
|
|
|
|
class SettingsAuthorizationPolicyTest extends TestCase
|
|
|
|
|
{
|
2026-03-04 15:56:58 +01:00
|
|
|
use AuthorizationPolicyTestSupport;
|
|
|
|
|
|
2026-02-24 08:49:40 +01:00
|
|
|
public function testViewRequiresSettingsViewPermission(): void
|
|
|
|
|
{
|
2026-03-13 11:31:33 +01:00
|
|
|
$permissionService = $this->createMock(PermissionService::class);
|
|
|
|
|
$permissionService->expects($this->once())
|
2026-02-24 08:49:40 +01:00
|
|
|
->method('userHas')
|
|
|
|
|
->with(4, PermissionService::SETTINGS_VIEW)
|
|
|
|
|
->willReturn(false);
|
|
|
|
|
|
2026-03-13 11:31:33 +01:00
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
2026-02-24 08:49:40 +01:00
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_VIEW, [
|
|
|
|
|
'actor_user_id' => 4,
|
|
|
|
|
]);
|
|
|
|
|
|
2026-03-04 15:56:58 +01:00
|
|
|
$this->assertForbiddenDecision($decision);
|
2026-02-24 08:49:40 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testViewReturnsUpdateCapability(): void
|
|
|
|
|
{
|
2026-03-13 11:31:33 +01:00
|
|
|
$permissionService = $this->permissionGatewayAllowing([
|
2026-03-04 15:56:58 +01:00
|
|
|
4 => [PermissionService::SETTINGS_VIEW, PermissionService::SETTINGS_UPDATE],
|
|
|
|
|
]);
|
2026-02-24 08:49:40 +01:00
|
|
|
|
2026-03-13 11:31:33 +01:00
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
2026-02-24 08:49:40 +01:00
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_VIEW, [
|
|
|
|
|
'actor_user_id' => 4,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$this->assertTrue($decision->isAllowed());
|
|
|
|
|
$this->assertTrue((bool) ($decision->attribute('capabilities', [])['can_update_settings'] ?? false));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testUpdateRequiresSettingsUpdatePermission(): void
|
|
|
|
|
{
|
2026-03-13 11:31:33 +01:00
|
|
|
$permissionService = $this->createMock(PermissionService::class);
|
|
|
|
|
$permissionService->expects($this->once())
|
2026-02-24 08:49:40 +01:00
|
|
|
->method('userHas')
|
|
|
|
|
->with(8, PermissionService::SETTINGS_UPDATE)
|
|
|
|
|
->willReturn(false);
|
|
|
|
|
|
2026-03-13 11:31:33 +01:00
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
2026-02-24 08:49:40 +01:00
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_UPDATE, [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
2026-03-04 15:56:58 +01:00
|
|
|
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
2026-02-24 08:49:40 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testBrandingUpdateRequiresSettingsUpdatePermission(): void
|
|
|
|
|
{
|
2026-03-13 11:31:33 +01:00
|
|
|
$permissionService = $this->createMock(PermissionService::class);
|
|
|
|
|
$permissionService->expects($this->once())
|
2026-02-24 08:49:40 +01:00
|
|
|
->method('userHas')
|
|
|
|
|
->with(8, PermissionService::SETTINGS_UPDATE)
|
|
|
|
|
->willReturn(false);
|
|
|
|
|
|
2026-03-13 11:31:33 +01:00
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
2026-02-24 08:49:40 +01:00
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_BRANDING_UPDATE, [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
2026-03-04 15:56:58 +01:00
|
|
|
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
2026-02-24 08:49:40 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testTokenRevokeRequiresSettingsUpdatePermission(): void
|
|
|
|
|
{
|
2026-03-13 11:31:33 +01:00
|
|
|
$permissionService = $this->createMock(PermissionService::class);
|
|
|
|
|
$permissionService->expects($this->once())
|
2026-02-24 08:49:40 +01:00
|
|
|
->method('userHas')
|
|
|
|
|
->with(8, PermissionService::SETTINGS_UPDATE)
|
|
|
|
|
->willReturn(false);
|
|
|
|
|
|
2026-03-13 11:31:33 +01:00
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
2026-02-24 08:49:40 +01:00
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_TOKENS_REVOKE, [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
2026-03-04 15:56:58 +01:00
|
|
|
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
2026-02-24 08:49:40 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testUserLifecycleRunRequiresSettingsUpdatePermission(): void
|
|
|
|
|
{
|
2026-03-13 11:31:33 +01:00
|
|
|
$permissionService = $this->createMock(PermissionService::class);
|
|
|
|
|
$permissionService->expects($this->once())
|
2026-02-24 08:49:40 +01:00
|
|
|
->method('userHas')
|
|
|
|
|
->with(8, PermissionService::SETTINGS_UPDATE)
|
|
|
|
|
->willReturn(false);
|
|
|
|
|
|
2026-03-13 11:31:33 +01:00
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
2026-02-24 08:49:40 +01:00
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_USER_LIFECYCLE_RUN, [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
2026-03-04 15:56:58 +01:00
|
|
|
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
2026-02-24 08:49:40 +01:00
|
|
|
}
|
test(security): cover tenant-scope, settings authz allow paths, auth gateways
Cluster 1 der Testabdeckungs-Initiative (.agents/runs/TEST-SEC-COVERAGE-001).
+38 Tests / +233 Assertions, nur tests/** veraendert.
- SettingsAuthorizationPolicyTest: Allow-Pfade fuer UPDATE/BRANDING_UPDATE/
TOKENS_REVOKE/USER_LIFECYCLE_RUN plus Unknown-Ability — schliesst die
Halb-Test-Luecke, die zuvor nur Deny-Pfade fuer 4 von 5 Abilities pruefte.
- AssignableRoleServiceTest: neu (GR-TEST-001, vorher nur transitiv via
UserAssignmentServiceTest gedeckt).
- AuthCryptoGatewayTest: neu (Roundtrip + Fehlerpfad, GR-SEC-005).
- AuthSettingsGatewayTest: neu (Delegation zu 5 Settings-Sub-Gateways).
- UserTenantContextServiceTest: neu, 18 Tests, Tenant-Scope-Logik
(GR-SEC-009) — current/primary/fallback, inactive-filter, assign-checks.
LdapConnectionGateway und OidcHttpGateway bleiben bewusst ohne Direkttests:
beide sind architektonische Test-Seams (dokumentiert im Docblock bzw. reiner
statischer Curl-Delegator). Ihre Logik ist ueber Konsumenten-Tests
(LdapAuthServiceTest, MicrosoftOidcServiceTest) bereits gedeckt.
Gates: QG-001 (1945 Tests) / QG-002 (PHPStan L5) / QG-003 (Architecture) /
QG-006 (php-cs-fixer) pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-22 18:57:43 +02:00
|
|
|
|
|
|
|
|
public function testUpdateAllowsWhenPermissionGranted(): void
|
|
|
|
|
{
|
|
|
|
|
$permissionService = $this->permissionGatewayAllowing([
|
|
|
|
|
8 => [PermissionService::SETTINGS_UPDATE],
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
|
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_UPDATE, [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$this->assertTrue($decision->isAllowed());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testBrandingUpdateAllowsWhenPermissionGranted(): void
|
|
|
|
|
{
|
|
|
|
|
$permissionService = $this->permissionGatewayAllowing([
|
|
|
|
|
8 => [PermissionService::SETTINGS_UPDATE],
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
|
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_BRANDING_UPDATE, [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$this->assertTrue($decision->isAllowed());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testTokenRevokeAllowsWhenPermissionGranted(): void
|
|
|
|
|
{
|
|
|
|
|
$permissionService = $this->permissionGatewayAllowing([
|
|
|
|
|
8 => [PermissionService::SETTINGS_UPDATE],
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
|
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_TOKENS_REVOKE, [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$this->assertTrue($decision->isAllowed());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testUserLifecycleRunAllowsWhenPermissionGranted(): void
|
|
|
|
|
{
|
|
|
|
|
$permissionService = $this->permissionGatewayAllowing([
|
|
|
|
|
8 => [PermissionService::SETTINGS_UPDATE],
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
|
|
|
|
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_USER_LIFECYCLE_RUN, [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$this->assertTrue($decision->isAllowed());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testUnknownAbilityIsDeniedWithServerError(): void
|
|
|
|
|
{
|
|
|
|
|
$permissionService = $this->createMock(PermissionService::class);
|
|
|
|
|
$permissionService->expects($this->never())->method('userHas');
|
|
|
|
|
|
|
|
|
|
$policy = new SettingsAuthorizationPolicy($permissionService);
|
|
|
|
|
$decision = $policy->authorize('admin.settings.nonexistent', [
|
|
|
|
|
'actor_user_id' => 8,
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
$this->assertDeniedDecision($decision, 500, 'authorization_ability_not_supported');
|
|
|
|
|
}
|
2026-02-24 08:49:40 +01:00
|
|
|
}
|